[Bubblewrap] Scrub inherited FTP proxy env variables - #914
Merged
Soham Das (SohamDas2021) merged 1 commit intoAug 14, 2026
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds FTP proxy variables to MXC’s managed proxy environment set and extends regression tests.
Changes:
- Scrubs uppercase and lowercase FTP proxy variables.
- Tests shared and Bubblewrap proxy handling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/core/wxc_common/src/proxy_env.rs |
Adds FTP variables to managed proxy keys. |
src/backends/bubblewrap/common/src/bwrap_command.rs |
Tests FTP variable scrubbing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ae9db9df-6439-46c3-9cb4-fd70e7cc43a3
Soham Das (SohamDas2021)
force-pushed
the
user/sodas/bwrap-proxy-env-hygiene
branch
from
August 14, 2026 21:25
61dc1d9 to
509bbf4
Compare
Branden Bonaby (bbonaby)
approved these changes
Aug 14, 2026
Soham Das (SohamDas2021)
deleted the
user/sodas/bwrap-proxy-env-hygiene
branch
August 14, 2026 21:56
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Adds FTP_PROXY and ftp_proxy to the managed proxy-variable set so caller-supplied FTP proxy settings cannot conflict with an MXC-configured proxy. Extends shared and Bubblewrap unit tests.
🔗 References
Refs AB#62864253.
🔍 Validation
✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see docs/pull-requests.md)📋 Issue Type
GitHub Actions runs the PR validation build automatically. The ADO pipeline
(
MXC-PR-Build) is the Azure version of the PR pipeline, kept in parity with the GitHubActions build; it runs on merge to
main, and Microsoft reviewers with write access can trigger iton a PR with
/azp run. See docs/pull-requests.md.If the
dependency-feed-checkcheck fails on a new dependency, the crate must be added tothe feed before the PR can pass. See docs/pull-requests.md
for the steps.
Microsoft Reviewers: Open in CodeFlow